[discussion] Access the Context's index and length #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually setting |
…es onto the stack
| this.of = len; | ||
|
|
||
| if(idx === undefined && len === undefined) { | ||
| idx = this.tail && this.tail.index; |
|
I would like to get something like this in for Dust@3 in which I don't plan on supporting IE8. Shall we make this a getter? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( instead of pushing our own copies onto the stack )
I think anything that manually manipulates the stack directly is a smell. We already have these properties available as
context.stack.indexandcontext.stack.of. It doesn't seem to make sense to directly reach into the stack's head and manually set them there.Instead, we can short-circuit
getin these cases.This also has the side effect of not polluting someone's
context.current()with something they didn't expect to be there.I would just like to get some discussion on this one, I'm not convinced it's correct yet.